Library url support #156
Merged
Library url support #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks passed. 🎉 |
Member
Author
|
woohoo! And I just finished writing a ticket to CircleCI support asking what the heck are we supposed to do if external PRs can't be tested using orbs? I'm not sure what the answer is, but we will see. :) Let's merge this guy, and I'll draft a release asap. |
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-opening of #154 to trigger tests - it looks like Circle has added new security "features" that the orb will not run if it's a PR opened by a non-org member. This could be an issue in the future we will need to address, for now I'm trying opening here (including all commits from #154).