fixing bug with instance stop all #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
lgtm, |
Member
Author
|
It's going to take me a few cycles to get 3.1 testing on Travis, I need to step away for a bit but I'll be back! |
Member
Author
|
@al3x609 I think your formatting of the version string was not in the right spot, all the tests in the matrix didn't work :/ |
Member
Author
|
This is very bad - TravisCI is all over the place. The only consistency is that there are random md5sum check fails and other random errors. Unfortunately this isn't going to be merged any time soon. |
Contributor
|
ok, WIP, for future, release, thanks @vsoch for your time. :) |
Member
Author
|
I'm restoring to the old version, someone else can address this that warrants needing it. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will close #86 , fixing the bug with instance stop all.