Skip to content

Conversation

@pierlauro
Copy link
Contributor

Implemented features:

  • When the user is not sudo or doesn't want to use a custom resolv.conf, don't generate hosts and resolv files
  • When the user is not sudo, don't use bridged networking (because it would not work)

@pierlauro pierlauro mentioned this pull request Feb 6, 2020
@vsoch
Copy link
Member

vsoch commented Feb 6, 2020

Great! Could you please update the CHANGELOG (add a line for the change) and bump the version in scompose/version.py to correspond with it? I'm not at keyboard yet but can definitely test this out today.

@vsoch
Copy link
Member

vsoch commented Feb 6, 2020

okay pulling to test locally! If all is well I'll do the merge by pushing to master. Give me a little bit of time to test.

vsoch added a commit that referenced this pull request Feb 6, 2020
@vsoch vsoch merged commit a324d15 into singularityhub:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants