This repository was archived by the owner on Oct 26, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Switch to CMake and use vcpkg. #30
Open
judemille
wants to merge
11
commits into
skiselkov:master
Choose a base branch
from
judemille:cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
CMake may be painful, but it's definitely less painful than QMake. This whole PR should reduce the codebase's own size, as well as making the build more resilient. This also avoids the library re-exporting all of its dependencies. |
Author
|
Rebased onto current revision. |
Build not tested on platforms other than Linux. Request tests by users of Windows and Mac to ensure the build succeeds.
My patches were merged upstream.
Author
|
Now it's actually rebased onto the current revision. |
Needed to actually get 7zip fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build not tested on platforms other than Linux.
Removes dependencies from the build tree, and in general does significant cleanup.