MNT: Change placeholder character to control character#258
Merged
adrinjalali merged 4 commits intoskops-dev:mainfrom Dec 19, 2022
Merged
MNT: Change placeholder character to control character#258adrinjalali merged 4 commits intoskops-dev:mainfrom
adrinjalali merged 4 commits intoskops-dev:mainfrom
Conversation
BenjaminBossan
approved these changes
Dec 19, 2022
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Correct me if I'm wrong, this change wouldn't make a bug completely impossible, just (even more) unlikely. If so, I'm happy with the change.
Collaborator
Author
You're correct. If a user tried to pass in ASCII control characters into their table names, it would perform differently from how they expect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change that swaps from using an arbitrary string of real world characters to a unicode control character.
This should reduce the risk of bugs (e.g, the original code would cause bugs if a user decided to use '$%!?' in their model card subsection or table), and the
unit seperatorfeels a good fit for this use case.