Skip to content

MNT: Change placeholder character to control character #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrinjalali merged 4 commits into from
Dec 19, 2022
Merged

MNT: Change placeholder character to control character #258

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a58b034
Change placeholder character to control character
E-Aho Dec 17, 2022
68daa27
Change to using curses instead of hard coded control character
E-Aho Dec 19, 2022
084309e
Remove curses code
E-Aho Dec 19, 2022
5716a2d
Update coments for ascii control chars
E-Aho Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions skops/card/_model_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def _clean_table(table: str) -> str:
# replace line breaks "\n" with html tag <br />, however, leave end-of-line
# line breaks (eol_lb) intact
eol_lb = "|\n"
placeholder = "$%!?" # arbitrary string that never appears naturally
placeholder = "\x1f" # unit separator control character (ASCII control char 31)
table = (
table.replace(eol_lb, placeholder)
.replace("\n", "<br />")
Expand Down Expand Up @@ -195,7 +195,7 @@ def split_subsection_names(key: str) -> list[str]:
The individual (sub)sections.

"""
placeholder = "$%!?" # arbitrary sting that never appears naturally
placeholder = "\x1f" # unit separator control character (ASCII control char 31)
key = key.replace("\\/", placeholder)
parts = (part.strip() for part in key.split("/"))
return [part.replace(placeholder, "/") for part in parts]
Expand Down