MNT fixed test for QuantileRegressor#374
Merged
BenjaminBossan merged 2 commits intoskops-dev:mainfrom Jun 27, 2023
Merged
Conversation
BenjaminBossan
approved these changes
Jun 26, 2023
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Besides a small typo, this LGTM. Thanks a lot for your initiative Edoardo.
The failing tests seem to be unrelated, so this can be merged from my POV.
What I do wonder though: Does this mean that using the default solver for QuantileRegressor raises an error? That seems pretty bad. Ping @adrinjalali
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Collaborator
|
The error that occurs is very strange, as it seems like an outdated sklearn version is being used. I could reproduce the error locally yesterday, but cannot do so today (new sklearn nightly release since then). I therefore assume the error is gone and it's a caching issue on GH or something. Anyway, the error is not related to this PR so it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Some tests are failing because the default
solver="interior-point"ofQuantileRegressoris not available inscipy>=1.11.0. Please see these tests as an example.scikit-learn>=1.4.0will change the default. In the meantime, this PR should fix the issue .