Skip to content

MNT fixed test for QuantileRegressor #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminBossan merged 2 commits into from
Jun 27, 2023
Merged

MNT fixed test for QuantileRegressor #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e751c6
fixed test for QuantileRegressor
EdAbati Jun 26, 2023
204117f
Update skops/io/tests/test_persist.py
EdAbati Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion skops/io/tests/test_persist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
_enforce_estimator_tags_y,
_get_check_estimator_ids,
)
from sklearn.utils.fixes import parse_version, sp_version

import skops
from skops.io import dump, dumps, get_untrusted_types, load, loads
Expand Down Expand Up @@ -136,7 +137,16 @@ def _tested_estimators(type_filter=None):
category=SkipTestWarning,
message="Can't instantiate estimator",
)
estimator = _construct_instance(Estimator)
if name == "QuantileRegressor" and sp_version >= parse_version(
"1.11.0"
):
# The solver "interior-point" (the default solver in
# scikit-learn < 1.4.0) is not available in scipy >= 1.11.0. The
# default solver will be "highs" from scikit-learn >= 1.4.0.
# https://scikit-learn.org/stable/modules/generated/sklearn.linear_model.QuantileRegressor.html
estimator = _construct_instance(partial(Estimator, solver="highs"))
else:
estimator = _construct_instance(Estimator)
# with the kind of data we pass, it needs to be 1 for the few
# estimators which have this.
if "n_components" in estimator.get_params():
Expand Down