MNT update linters and use ruff#397
Merged
adrinjalali merged 6 commits intoskops-dev:mainfrom Oct 13, 2023
Merged
Conversation
Merged
Collaborator
Member
Author
|
The CI here is passing the linter stage, so we can kinda consider this green I guess. |
BenjaminBossan
approved these changes
Oct 13, 2023
Collaborator
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
LGTM, thanks. Did you ruff to be better apart from speed, which I don't feel was a big issue to begin with.
Member
Author
It's speed, as well as having all the rules in one linter. We've switched in large projects to ruff and we're very happy with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces flake8 and isort with ruff, which is much faster, updates linter versions, and fixes issues due to the version upgrades and using ruff.