Skip to content

DEPR hub_utils.push#398

Merged
adrinjalali merged 5 commits intoskops-dev:mainfrom
adrinjalali:tst/disable
Oct 23, 2023
Merged

DEPR hub_utils.push#398
adrinjalali merged 5 commits intoskops-dev:mainfrom
adrinjalali:tst/disable

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

This deprecates hub_utils.push since create_repo now also has strict rate limits.

The linter issue should be fixed by merging #397 and then updating this PR.

@adrinjalali
Copy link
Copy Markdown
Member Author

Need to replace all instances of hub_utils.push to using huggingface_hub utils. We probably need to make those as comments instead of running them since our doc build would otherwise fail too.

@adrinjalali
Copy link
Copy Markdown
Member Author

Codecov fail be due to push not being tested. Ready for review @BenjaminBossan

@adrinjalali
Copy link
Copy Markdown
Member Author

Ping @BenjaminBossan , I can do a release once we merge this one.

Copy link
Copy Markdown
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@adrinjalali adrinjalali merged commit 60d7063 into skops-dev:main Oct 23, 2023
@adrinjalali adrinjalali deleted the tst/disable branch October 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants