This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Conversation
Rather than embedding our template into our binary using `implant` instead use the new go-embed system: * golang/go#41191 * https://go.googlesource.com/proposal/+/master/design/draft-embed.md This required rebuilding go from source (took five minutes!): * https://golang.org/doc/install/source Once done I used the following repository for reference: * https://github.com/mattn/go-embed-example Seems to work, but we'll hold off merging this unless/until we have go 1.16.x released because requiring a source build is a pain.
Owner
Author
|
Confirmed this builds/works on the newly released 1.16 beta-release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than embedding our template into our binary using
implantthis pull-request instead uses the new go-embed system:This required rebuilding go from source (took five minutes!):
Once done I used the following repository for reference:
Seems to work, but we'll hold off merging this unless/until we have go 1.16.x released because requiring a source build is a pain.