This repository was archived by the owner on May 3, 2021. It is now read-only.
Switch to go modules, remove some code duplication#25
Merged
skx merged 2 commits intoskx:masterfrom Nov 7, 2020
Merged
Conversation
the go source tree, and dependencies pinned. Use go:generate annotation to generate the static resources go file, and add it to gitignore (generated stuff can be left out of source control to prevent stale builds)
included as a sub-template. Parse all the templates upfront on server start, and look them up when needed. This 1. Reduces code duplication loading templates from resources and 2. Saves re-parsing templates on every page load More work can be done removing duplication from the HTML files and stylesheets. Componentizing the HTML like this should eventually allow composite views for different sized screens: e.g. including the message view and message list on the same page in wide screen formats.
Owner
|
I admit I've not even built this project for some time, since I switched from my own self-hosted IMAP/SMTP server to paying for gsuite. That said if the project is useful to others I'm certainly willing and able to review/accept changes. I have no objection to anything you've committed - only the minor comment that the CI is now broken, as the implant tool is missing (as a guess). I'm happy to accept this and merge then fixup shortly afterward. I expect that when we have go 1.16 I'd be moving over to using the So while the change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm thinking about using your project (I've been thinking about writing a go-based webmail for a year! just didn't start it yet...), and noted that you still need sending capability for this to be a fully functional webmail. If it's OK, I'd like to help with that!
While taking a look around the code you have so far, I noted a couple of suggestions that might help make it easier to work on in future, in particular:
implant, this approach means that your build instructions don't have to change if you change the embedding tool (or indeed if you want to execute several external code generation tools). The build process then simply looks like:Feel free to close this PR if you aren't working on this project any more and don't have time to review,
Thanks for writing this piece of software, it makes a nice change from all the PHP based webmails out there!