[Repo Assist] fix: use path.join for temp file, fix stdout buffering, reject on exit code 0

[github-actions]

🤖 This is an automated PR from Repo Assist, an AI assistant.

Summary

Three focused fixes for correctness and Windows compatibility in extension.js.

Changes

1. Fix Windows-incompatible temp file path (addresses PR #23)

Before:

let fileName = TmpDir + "/temp-" + randomPart + ".php";

After:

let fileName = path.join(TmpDir, "temp-" + randomPart + ".php");

On Windows, os.tmpdir() returns a path with backslashes (C:\Users\...\AppData\Local\Temp). Concatenating a hardcoded / produces an invalid mixed-separator path like C:\...\Temp/temp-abc.php. path.join uses the correct separator for the platform. PR #23 (open since 2018) proposed the same fix.

2. Reject formatter Promise on exit code 0 (fixes #39, see also PR #41, PR #48)

When phpcbf exits with code 0 (file is already clean — nothing to fix), the formatter's Promise previously neither resolved nor rejected. VS Code's formatter API waits indefinitely for the Promise to settle, causing the "Formatting…" spinner to run forever and blocking subsequent saves. Calling reject() immediately signals VS Code that there are no edits.

3. Fix dead stdout error handler — show real error messages on exit code 3

Bug: The original code checked if (phpcbfError) synchronously right after constructing the Promise. At that point phpcbfError was always false (the exit event hasn't fired yet), so the stdout error handler was never registered. Users got a silent failure with no indication of what went wrong.

Fix: Buffer all stdout in a single always-registered handler. When exit code 3 fires, display the buffered output as an error message (falling back to a generic message if stdout was empty), then call reject().

This also consolidates the two previous separate exec.stdout.on("data", ...) registrations (one for errors, one for debug mode) into a single handler.

Files Changed

File	Change
extension.js	path.join for temp file; buffer stdout; reject() on exit code 0; error display + reject() on exit code 3

Relationship to Other Open PRs

• Supersedes PR [Repo Assist] fix: reject promise on phpcbf exit codes 0 and 3 to prevent hang #48 (exit code 0/3 reject) — this PR includes the same exit code fixes plus the path and stdout improvements
• Addresses the concern from PR added reject() for phpcbf exit codes 0 & 3 to stop editor hanging when there are no fixable errors found #41 (exit code 0/3) — same root cause, applied to current codebase
• Resolves the path-separator concern from PR Use path.sep when building path to temporary file #23 (Windows path.sep)

Closes #39

Test Status

This extension requires a live VS Code instance and cannot be tested headlessly. The changes are additive/corrective with no logic changes for the working exit codes (1 and 2).

Manual test steps:

1. Open a PHP file already fully formatted → save → spinner should clear immediately (was: hangs forever)
2. Trigger phpcbf with a broken config → VS Code should show a real error message (was: silent failure)
3. Open a PHP file with fixable errors → save → file is correctly updated (exit codes 1/2 unchanged)

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f