[Repo Assist] fix: use TextEdit[] in onWillSaveTextDocument instead of executeCommand (fixes #35)

[github-actions]

🤖 This is an automated PR from Repo Assist, an AI assistant.

Summary

Fixes a bug in onWillSaveTextDocument where editor.action.formatDocument was dispatched inside event.waitUntil() instead of returning TextEdit[] directly.

Root Cause

The TextDocumentWillSaveEvent.waitUntil() API accepts a Thenable(TextEdit[]) to apply edits atomically as part of the save transaction. The previous code passed a Thenable(void) from commands.executeCommand("editor.action.formatDocument"), which has two problems:

1. Wrong document: editor.action.formatDocument always formats the active text editor, not event.document. If a user saves a non-focused PHP tab, the active (wrong) document gets formatted instead.

2. Outside the save transaction: Edits applied via the command bypass VS Code's save-edit mechanism. The waitUntil API is designed to inject TextEdit[] directly into the pending save, so the changes are part of the same undo step.

These issues can cause the onWillSaveTextDocument-listener ERROR: timeout reported in #35, especially when combined with phpcbf's Promise not settling on exit code 0 (a separate issue addressed by PR #49).

Fix

Call phpcbf.format(event.document) directly — exactly as provideDocumentFormattingEdits does — and return [new vscode.TextEdit(range, text)] to waitUntil. On rejection (nothing to fix, or error), return [] so VS Code's save cycle completes normally without a timeout.

Files Changed

File	Change
extension.js	Replace commands.executeCommand("editor.action.formatDocument") with direct phpcbf.format(event.document) returning TextEdit[]

Relationship to Other PRs

• Complements PR [Repo Assist] fix: use path.join for temp file, fix stdout buffering, reject on exit code 0 #49 (reject on exit code 0, path.join, stdout buffer) — that PR fixes phpcbf's Promise not settling; this PR fixes the architectural issue with the save handler
• No conflicts with PR [Repo Assist] fix: use path.join for temp file, fix stdout buffering, reject on exit code 0 #49, [Repo Assist] feat: add VS Code output channel for debug logging and error display #50, or [Repo Assist] fix: replace deprecated async fs.exists with fs.existsSync in addRootPath #51

Closes #35

Test Status

This extension requires a live VS Code instance and cannot be tested headlessly.

Manual test steps:

1. Set "phpcbf.onsave": true and "editor.formatOnSave": false in settings
2. Open a PHP file with fixable errors and save → file should be corrected
3. Open a PHP file already clean and save → save should complete immediately with no spinner hang
4. Open two PHP tabs, focus one, then save the other → the correct (saved) file should be formatted, not the focused one

Generated by Repo Assist · ◷

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f