[BE-Fix] 구글 캘린더 업데이트 연동 버그 수정

[kwon204]

변경 여부 검사를 업데이트 하기 전에 미리 체크하기로 수정

#️⃣ 연관된 이슈>

• [Feature] 구글 캘린더 일정 연동 기능 구현 #137

📝 작업 내용> 이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

• 변경 여부를 업데이트 하고 나서 체크하고 있어서 제대로 연동이 되고 있지 않았습니다........
• 변경 여부 검사를 업데이트 하기 전에 미리 체크하기로 수정했습니다......

🙏 여기는 꼭 봐주세요! > 리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Summary by CodeRabbit

• Refactor
  • Improved the process for syncing your personal events with Google Calendar for enhanced reliability. Now, new events and updates are handled more consistently, ensuring your calendar remains accurate and up-to-date. These internal enhancements deliver a smoother, more dependable experience when managing your events.

[coderabbitai]

Walkthrough

This pull request refactors the synchronization logic within the PersonalEventService. The logic for handling Google Calendar integrations is now split into two private methods, syncInsert and syncUpdate, which are called by the updateWithRequest method to decide whether to insert or update an event. The method formerly named isChanged has been renamed to isDateTimeChanged, and the redundant haveToSync method has been removed.

Changes

File	Change Summary
backend/.../personal_event/PersonalEventService.java	- Added private methods: syncInsert and syncUpdate - Updated updateWithRequest to use new sync methods and publish corresponding events - Renamed isChanged to isDateTimeChanged and removed haveToSync

Sequence Diagram(s)

sequenceDiagram
    participant U as User Request
    participant S as PersonalEventService
    participant G as Google Calendar Sync
    U->>S: send updateWithRequest
    S->>S: Evaluate syncInsert & syncUpdate
    alt when syncInsert is true
        S->>G: Retrieve calendar ID and update event with new ID
        S->>G: Publish InsertPersonalEvent
    else when syncUpdate is true
        S->>G: Publish UpdatePersonalEvent
    end
    S->>U: return response

Loading

Possibly related PRs

• [BE-Fix] 개인 일정 수정 시 구글 캘린더에 반영되지 않는 버그 수정 #227: Modifications in the updateWithRequest method for personal event synchronization align with this update.
• [BE-Fix] 구글에서 반영된 일정이 항상 조정 불가능으로 되는 버그 수정 #303: Adjustments in the synchronization logic and parameters for calendar events have a strong connection.
• [BE-Feat] 개인 일정 SSE 알림 구현 #237: Introduction of encapsulated sync methods matches the refactoring of Google Calendar event handling.

Suggested reviewers

• efdao

Poem

I'm a rabbit hopping through lines of code,
Syncing events with a rhythmic mode.
Inserting and updating with a graceful twist,
I skip through methods, too good to resist.
With CodeRabbit cheer, I celebrate this code!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe917f1 and 1778076.

📒 Files selected for processing (1)

• backend/src/main/java/endolphin/backend/domain/personal_event/PersonalEventService.java (4 hunks)

🔇 Additional comments (5)

backend/src/main/java/endolphin/backend/domain/personal_event/PersonalEventService.java (5)

134-136: Clear separation of sync conditions improves bug fix implementation.

Excellent refactoring by separating the synchronization conditions into explicit checks before updating the personal event. This addresses the core issue described in the PR by ensuring checks happen before the update process.

---

142-148: Logical flow restructured for clarity.

The restructured conditional logic provides a clearer and more maintainable approach to handling Google Calendar synchronization. This implementation properly handles the different synchronization scenarios separately.

---

153-157: Well-structured synchronization condition for updates.

Good use of StringUtils.equals() for safer string comparison that handles null values properly. The method clearly identifies when an event should be updated in Google Calendar based on relevant content changes.

---

159-163: Appropriate logic for detecting when a new calendar event should be inserted.

The syncInsert method correctly identifies when a personal event needs to be inserted into Google Calendar based on the absence of Google identifiers, which aligns with the fix described in the PR.

---

287-290: Method rename improves clarity of purpose.

Renaming from isChanged to isDateTimeChanged more accurately reflects what this method checks, which helps with code readability and maintenance.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[efdao]

고생하셨습니다.