[BE-Fix] 토큰 재할당 뒤 적용이 되지 않던 버그 수정

[kwon204]

#️⃣ 연관된 이슈>

• [BE-Fix] 구글 캘린더 업데이트 연동 버그 수정 #308

📝 작업 내용> 이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

자바 람다식에서 지역변수를 사용하면 캡쳐 시점의 값으로 고정하기 때문에 token 대신 user.getAccessToken()을 사용해서 변경된 토큰을 사용할 수 있도록 수정

🙏 여기는 꼭 봐주세요! > 리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Summary by CodeRabbit

• Refactor
  • Optimized the calendar synchronization process for seamless and reliable service, maintaining the same functionality while paving the way for smoother future enhancements.

[coderabbitai]

Walkthrough

This change refactors the GoogleCalendarService class by removing local variable declarations for the access token in the methods updatePersonalEventToGoogleCalendar, deletePersonalEventFromGoogleCalender, and getPrimaryCalendar. Instead of storing the token in a variable, the code now directly calls user.getAccessToken() when constructing the authorization header for HTTP requests. The overall functionality and external behavior remain unchanged.

Changes

File(s)	Change Summary
backend/.../GoogleCalendarService.java	Removed intermediate variables for access tokens and directly used user.getAccessToken() in methods

Suggested reviewers

• efdao

Poem

I'm a rabbit darting through the code,
Hopping over tokens with a swift new mode.
No extra stops or needless delay,
Just clean, direct hops all the way.
Carrot cheers for changes today! 🐰

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 850ef34 and 19a0f2e.

📒 Files selected for processing (1)

• backend/src/main/java/endolphin/backend/global/google/GoogleCalendarService.java (3 hunks)

🔇 Additional comments (3)

backend/src/main/java/endolphin/backend/global/google/GoogleCalendarService.java (3)

127-127: Well-implemented fix for token refresh issue.

This change properly resolves the issue where token reassignments weren't being applied within lambda expressions. By directly calling user.getAccessToken() instead of capturing a local token variable, the code will always retrieve the most up-to-date token value whenever the lambda executes.

---

158-158: Consistent application of token refresh fix.

This change follows the same pattern as the previous fix, ensuring the token refresh issue is addressed consistently across different methods. Direct access to user.getAccessToken() ensures the most current token is always used.

---

267-267: Comprehensive fix for token capture issue.

This change completes the fix across all methods that access tokens within lambda expressions. The thorough application of this solution demonstrates a good understanding of how Java lambdas capture variables and prevents potential token refresh issues in the future.

It might be helpful to add a brief comment in the code explaining why direct access is used rather than capturing in a local variable, to prevent future developers from accidentally reintroducing this issue:

+    // Directly access user.getAccessToken() inside lambdas to ensure the most current token is used
     .header(HttpHeaders.AUTHORIZATION, "Bearer " + user.getAccessToken())

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[efdao]

고생하셨습니다.