NETWORK-8987 - added createDate and modifyDate parameters to sg rule-list #1071
Conversation
allmightyspiff
left a comment
allmightyspiff
left a comment
There was a problem hiding this comment.
Make sure you get the unit tests to work properly, otherwise the code change is simple enough.
For the specific test that is failing, I'd recommend changing the test to make sure just the ID is right or a few other choice field.
Let me know if you have questions on how to run the unit tests.
…eateDate and modifyDate parameters
|
I modified the failing method in the securitygroup_test.py class to have the createDate and modifyDate parameters, as the error appeared to be a detected mismatch. My change has been added to this pull request. |
…ve invocation error in build
…gopal/softlayer-python into feature/NETWORK-8987
| 'portRangeMax': None, | ||
| 'createDate': None, | ||
| 'modifyDate': None}], | ||
| json.loads(result.output)) |
There was a problem hiding this comment.
Basically just needs 1 space so this line aligns with the opening { up top.
You can run tox -e analysis in the softlayer-python directory to make sure all integration tests pass locally.
…gopal/softlayer-python into feature/NETWORK-8987
…gopal/softlayer-python into feature/NETWORK-8987
3 participants
This adds the createDate and modifyDate parameters to the sg rule-list table under rule.py and to the mask under the get_securitygroup command under network.py.