Skip to content

NETWORK-8987 - added createDate and modifyDate parameters to sg rule-list #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allmightyspiff merged 9 commits into from
Nov 9, 2018
Merged

NETWORK-8987 - added createDate and modifyDate parameters to sg rule-list #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
649c8ae
NETWORK-8987 - added createDate and modifyDate parameters to sg rule-…
Anjana-Rajagopal Nov 6, 2018
6309d1d
NETWORK-8987 - modifying the rule class and test class to have the cr…
Anjana-Rajagopal Nov 8, 2018
b332392
NETWORK-8987 - fixing indentations within securitygroup_test to resol…
Anjana-Rajagopal Nov 8, 2018
477c3df
Merge branch 'feature/NETWORK-8987' of https://github.com/Anjana-Raja…
Anjana-Rajagopal Nov 9, 2018
c408939
NETWORK-8987 - fixing minor indentation to resolve pep8 error
Anjana-Rajagopal Nov 9, 2018
2e94a7b
NETWORK-8987 - fixing minor indentation to resolve pep8 error
Anjana-Rajagopal Nov 9, 2018
25ae8dd
Merge branch 'feature/NETWORK-8987' of https://github.com/Anjana-Raja…
Anjana-Rajagopal Nov 9, 2018
4790190
NETWORK-8987 - fixing minor indentation to resolve pep8 error
Anjana-Rajagopal Nov 9, 2018
543c06b
Merge branch 'feature/NETWORK-8987' of https://github.com/Anjana-Raja…
Anjana-Rajagopal Nov 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions SoftLayer/CLI/securitygroup/rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
'ethertype',
'portRangeMin',
'portRangeMax',
'protocol']
'protocol',
'createDate',
'modifyDate']


@click.command()
Expand Down Expand Up @@ -49,7 +51,9 @@ def rule_list(env, securitygroup_id, sortby):
rule.get('ethertype') or formatting.blank(),
port_min,
port_max,
rule.get('protocol') or formatting.blank()
rule.get('protocol') or formatting.blank(),
rule.get('createDate') or formatting.blank(),
rule.get('modifyDate') or formatting.blank()
])

env.fout(table)
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ def get_securitygroup(self, group_id, **kwargs):
'description,'
'''rules[id, remoteIp, remoteGroupId,
direction, ethertype, portRangeMin,
portRangeMax, protocol],'''
portRangeMax, protocol, createDate, modifyDate],'''
'''networkComponentBindings[
networkComponent[
id,
Expand Down
4 changes: 3 additions & 1 deletion tests/CLI/modules/securitygroup_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ def test_securitygroup_rule_list(self):
'remoteGroupId': None,
'protocol': None,
'portRangeMin': None,
'portRangeMax': None}],
'portRangeMax': None,
'createDate': None,
'modifyDate': None}],
json.loads(result.output))

def test_securitygroup_rule_add(self):
Expand Down