Skip to content

Conversation

@kremlin-
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Feb 20, 2020

Coverage Status

Coverage increased (+0.006%) to 93.833% when pulling 833700c on kremlin-:vdr-integration into 8c87513 on softlayer:master.

@allmightyspiff allmightyspiff self-requested a review February 20, 2020 22:14
@allmightyspiff allmightyspiff added the Storage Storage Systems label Feb 20, 2020
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Need a docs/cli/file.rst update
  2. Merge the file/block manager commands into the storage_utils manager
  3. I'd like a little more documented about what actually happens when you run these commands. If there is documentation being created that explains all that on cloud.ibm.com or something linking to it in the docs/cli area should be fine.
  4. Since the refreshDependentDuplicate command isn't out yet, this will likely be on-hold until it is public.
  5. Unit tests.

@allmightyspiff
Copy link
Member

I've refactored the file/block managers, which will likely conflict with your changes.

When you get a chance, you might want to pull in the changes from #1235 (or just wait until its merged to master).

The practical effect is that you'll just put your file/block manager new functions into the new storage manager since they are the exact same between file and block.

@allmightyspiff allmightyspiff merged commit 0e06b79 into softlayer:master Mar 4, 2020
@allmightyspiff allmightyspiff mentioned this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Systems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants