Skip to content

Issues1233 file and block refactor #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
allmightyspiff merged 10 commits into from
Mar 4, 2020
Merged

Issues1233 file and block refactor #1235

allmightyspiff merged 10 commits into from
Mar 4, 2020

Conversation

@allmightyspiff
Copy link
Member

@allmightyspiff allmightyspiff commented Feb 26, 2020

Refactors the FIle and Block managers into a unified manager called storage. File and Block managers now should contain code that is unique to each offering.

@allmightyspiff allmightyspiff self-assigned this Feb 26, 2020
@allmightyspiff allmightyspiff added Core Issues dealing with core functionality Storage Storage Systems labels Feb 26, 2020
@allmightyspiff allmightyspiff mentioned this pull request Feb 26, 2020
Closed
@allmightyspiff allmightyspiff linked an issue Feb 26, 2020 that may be closed by this pull request
slcli [block|file] volume-detail <bad name> throws exception #1229
Closed
@coveralls
Copy link

coveralls commented Feb 26, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 93.809% when pulling c64c058 on allmightyspiff:issues1233-fbRefactor into 8c87513 on softlayer:master.

@allmightyspiff allmightyspiff mentioned this pull request Feb 27, 2020
Merged
FernandoOjeda
FernandoOjeda approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@FernandoOjeda FernandoOjeda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and it is working well too.

caberos
caberos approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@caberos caberos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is good

@allmightyspiff allmightyspiff merged commit 2587d41 into softlayer:master Mar 4, 2020
@allmightyspiff allmightyspiff deleted the issues1233-fbRefactor branch March 4, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ATGE ATGE Awaiting requested review from ATGE

2 more reviewers

@caberos caberos caberos approved these changes

@FernandoOjeda FernandoOjeda FernandoOjeda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@allmightyspiff allmightyspiff

Labels

Core Issues dealing with core functionality Storage Storage Systems

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

slcli [block|file] volume-detail <bad name> throws exception

4 participants

@allmightyspiff @coveralls @caberos @FernandoOjeda