-
Notifications
You must be signed in to change notification settings - Fork 194
implement the new feature hw billing and vs billing #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
allmightyspiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Just make sure all the table column names start with a capital letter. And fix the few I mentioned specifically.
allmightyspiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Last thing please add these commands to docs\cli\hardware.rst and docs\cli\vs.rst
Thanks.
allmightyspiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the failing unit tests, I'd recommend changing them so they don't require an EXACT match on the output because if you change the output, the test fails. Id recommend just checking a few key fields exist in the output like how the vs_tests/ def test_bandwidth_vs_quite(self): does it
#1242