Conversation
- Make sure the parent directories of the configured log file locations exist (so we can use them) - or else create them - Move default location of hermes log into cache dir
jkelling
left a comment
jkelling
left a comment
There was a problem hiding this comment.
Let us discuss the naming of the --path option. (have to post this comment to remove my approving review.)
I agree we should talk about this. Can we please keep this out of this PR? This one is relevant for properly setting up folks with #110 / #180 for the DataCite meeting. IMHO changing the path command line option seems out of scope for this PR which is only about adapting the logging paths. (Which happens after the CLI option was given, so this is completely independent from how the option is looking like) |
|
@sdruskat you wanted this change so we have a nice oneliner in gitignore. May I ask for your review again so we can ship it in time? Thx! |
jkelling
left a comment
jkelling
left a comment
There was a problem hiding this comment.
The option-name issue is indeed outside of the scope, as the option existed before, I just noticed it here first.
Co-authored-by: jkelling <j.kelling@hzdr.de>
led02
left a comment
led02
left a comment
There was a problem hiding this comment.
Mostly okay, see not for requested change.
Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
|
I fixed the tests we broke. I will merge now, as all requested changes have been addressed and we need this done for tomorrow. (Usually not drawing that card of overriding our rules.) |
poikilotherm
dismissed stale reviews from led02 and jkelling
All requests have been addressed.
3 participants
Relates to #138