Skip to content

Comments

Boil down first CI tutorial#180

Merged
sdruskat merged 13 commits intofeature/35-first-user-tutorialfrom
pr-update/most-basic-ci-tutorial
May 23, 2023
Merged

Boil down first CI tutorial#180
sdruskat merged 13 commits intofeature/35-first-user-tutorialfrom
pr-update/most-basic-ci-tutorial

Conversation

@sdruskat
Copy link
Contributor

Tihs PR prepares a working tutorial for using GitHub Zenodo Sandbox publication via a template.

@sdruskat
Copy link
Contributor Author

Shoudl add a link to concept DOI in the last paragraph, pointing to Zenodo's "versioning DOIs" docs.

@sdruskat sdruskat marked this pull request as ready for review May 17, 2023 16:21
@sdruskat sdruskat requested review from led02 and poikilotherm May 17, 2023 16:21
@sdruskat
Copy link
Contributor Author

Shoudl add a link to concept DOI in the last paragraph, pointing to Zenodo's "versioning DOIs" docs.

Done in a5c2b08.
Ready for review now.

Copy link
Contributor

@jkelling jkelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the ["cff, "git"] harvest order.

Does the folder .hermes/curate remain in the repo after the publication PR is merged?

Copy link
Member

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of adding some more subtle changes. Hope this is to your liking, especially the workflow diagram. Tune as you see fit - otherwise good to go!

@sdruskat
Copy link
Contributor Author

I took the liberty of adding some more subtle changes. Hope this is to your liking, especially the workflow diagram. Tune as you see fit - otherwise good to go!

Cheers, I finetuned a bit. Will merge once the CI build is done.

@sdruskat sdruskat merged commit b0278f3 into feature/35-first-user-tutorial May 23, 2023
@sdruskat sdruskat deleted the pr-update/most-basic-ci-tutorial branch May 23, 2023 10:51
Copy link
Member

@led02 led02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I found some inconsistencies. This might be due to unclear wording. Yet, it does not correctly describe the process.

Comment on lines +70 to +71
[harvest.cff]
validate = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to switch off CFF validation here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only that it was copied from showcase (which I don't think has "version" perhaps?). Happy to remove.

Copy the [template for GitHub to Zenodo Sandbox publication](https://github.com/hermes-hmc/ci-templates/blob/main/TEMPLATE_hermes_github_to_zenodo.yml)
into the `.github/workflows/` directory in your repository, and rename it as you like (e.g. `hermes_github_to_zenodo.yml`).

Go through the file, and look for comments marked with `# ADAPT`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is just a litte too lazy. I would exprect at least some synopsis what and why to adapt...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to overburden the tutorial for this. Once we have a cleaner template (e.g. based on Marketplace Action), we can pull this in here.

Comment on lines +115 to +117
```{warning}
If you haven't adapted the workflow file, and push it to the branch `main`, you will create an automatic publication at this point.
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true: We create a new PR that needs to be closed before the publication is done (i.e., "curation step").

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +145 to +146
Now, whenever the GitHub Actions workflow is triggered, it will publish a new version of your repository to Zenodo Sandbox.
If you haven't adapted the workflow file, this will happen whenever you push to your `main` branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again: No, it only creates the curation PR that needs to be merged before the deposition takes place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 158 to 159
If the updates from the publication actually change the configuration file, or the `CITATION.cff` file,
HERMES will create another pull request after publication.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads rather cryptic... it's not the updates from the publication but the postprocessing that changes stuff...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, will adapt.

@sdruskat sdruskat mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants