Skip to content

Comments

Improve tutorial#185

Merged
sdruskat merged 10 commits intodevelopfrom
feature/improve-tutorial
May 23, 2023
Merged

Improve tutorial#185
sdruskat merged 10 commits intodevelopfrom
feature/improve-tutorial

Conversation

@sdruskat
Copy link
Contributor

Includes improvements such as mentioning setting a license in the CFF file for open access publication, and a list of improvements from @led02's post-merge comments in #180.

@sdruskat sdruskat marked this pull request as ready for review May 23, 2023 17:02
@sdruskat sdruskat requested a review from poikilotherm May 23, 2023 17:02
@sdruskat
Copy link
Contributor Author

@poikilotherm First of the last calls ;). Please review & merge if you're happy with the changes.

@poikilotherm
Copy link
Member

poikilotherm commented May 23, 2023

@sdruskat I fixed some language (you instead of we) and added some screenshots behind toggles. Pictures often say more than a 1000 words, but I still wanted you to have the feeling of a short page.

Please review and merge if you like it 😉

sdruskat added 3 commits May 23, 2023 21:15
- For future reference, the sphinx-togglebutton extension provides
a single global variable for changing toggle text, which is
useless; we should investigate alternatives.
@sdruskat
Copy link
Contributor Author

@sdruskat I fixed some language (you instead of we)

Cheers 👍

and added some screenshots behind toggles. Pictures often say more than a 1000 words, but I still wanted you to have the feeling of a short page.

The way they are set up, the toggles disrupt the flow. I'll change the text on them to make them slightly more useful.

Please review and merge if you like it 😉

I'll make some changes on top of yours. No hard feelings, but in the future, I wouldn't mind working with review suggestions rather than one content commit ;). Makes changes more atomic and much easier to work with.

Copy link
Member

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry for the forced changes in the commit, usually not doing that... 😉

@sdruskat sdruskat merged commit db570e6 into develop May 23, 2023
@sdruskat sdruskat deleted the feature/improve-tutorial branch May 23, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants