Conversation
led02
reviewed
Sep 5, 2022
Member
|
Included in #40 |
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Shall close this one then? |
We want to abort execution if process step cannot find any cache from harvest (which means the step did not run) and present an error to the user. If the harvesters itself did not run during the step (because disabled), this should not be a problem, as in the future we will only look for data from enabled harvesters.
led02
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements CodeMeta harvesting at its simplest. Implementation is POC still, I'd like to get some validation in there if possible. Still, comments are welcome. I left TODOs in there as reminders.