Skip to content

Comments

26 implement processing step#40

Merged
sdruskat merged 70 commits intodevelopfrom
26-implement-processing-step
Jan 11, 2023
Merged

26 implement processing step#40
sdruskat merged 70 commits intodevelopfrom
26-implement-processing-step

Conversation

@led02
Copy link
Member

@led02 led02 commented Sep 21, 2022 •
edited by poikilotherm
Loading

Closes #26
Closes #17
Closes #32
Closes #34

Sorry for the big evil commit. However, this is a somewhat working version that

  • Harvests data (from CITATION.cff, git history)
  • Assembles them into a common codemeta.json
  • Tracks the provenance of each entry
  • Has some basic logging and configuration implemented
  • Totally lacks documentation blush

Some stuff is lacking:

  • Extensive tests
  • Tutorials / docs
  • Maybe some ADR

jkelling and others added 15 commits September 1, 2022 10:57
@jkelling
Add simple git author harvester
7705566
@jkelling @sdruskat
harvest/git.py: AuthorData: Add arg type constaint
acfdf82 
Co-authored-by: Stephan Druskat <sdruskat@users.noreply.github.com>
@jkelling
git harvester: Add committer
8947b81
@jkelling @led02
Apply suggestions from code review
b5a20c3 
PEP-ified

Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
@led02
Add entry point for (pre-)processing
4a61db3
@led02
Merge remote-tracking branch 'origin/githarvester' into 26-implement-…
3a9e2b3 
…processing-step
@sdruskat
Add entrypoint for codemeta harvesting
8d518a9
@sdruskat
Add the most basic CodeMeta harvester
fe86e18
@sdruskat
Remove print statement
62da3b2
@sdruskat
Add tests and failing test for validation
8bdc3c8
@sdruskat
Clean up imports
e475dfc
@led02
After the weekend, save old stuff
05d53db
@led02
Ignore more build output
6c63604
@led02
Extract merge strategies and switch to ContextPath style access
c9a9800
@led02
Adapt workflow to latest changes
4652e91
This was referenced Sep 21, 2022
Closed
Closed
@led02 led02 mentioned this pull request Sep 22, 2022
Closed
sdruskat and others added 2 commits September 22, 2022 14:15
@sdruskat
Add tests to use fixtures
4cd6008
@led02
Fix errors that occured when merging codemeta
47901e8 
- Collect and handle errors during merge
- Better handling of incompatible types
@led02 led02 mentioned this pull request Sep 22, 2022
Merged
@led02 led02 marked this pull request as ready for review September 22, 2022 14:07
@led02 led02 requested review from jkelling and sdruskat September 22, 2022 14:07
@led02 led02 mentioned this pull request Sep 22, 2022
Closed
led02 and others added 23 commits January 11, 2023 13:22
@led02
Add missing dependency pyparsing
fcd43ac
@sdruskat
Merge remote-tracking branch 'origin/26-implement-processing-step' in…
e236d01 
…to 82-remove-quickfix-logging
@led02
Reduce accuracy of timestamp to seconds
8a50d4d
@poikilotherm
fix(docs): fix wrong Sphinx domains in docstrings
12c8f3c
@sdruskat
Merge branch '26-implement-processing-step' into 82-remove-quickfix-l…
a48c0cd 
…ogging
@poikilotherm
fix: ignore more HERMES cli outputs in git
8ff4d4c
@poikilotherm
refactor(cli): rename from haggis to hermes #29
9275646
@jkelling
constex, harvest: ep -> harverster; ts -> timestamp
509a063
@sdruskat
Merge pull request #91 from hermes-hmc/feature/29-renaming
6eb4cd7 
Feature/29 renaming from haggis to hermes
@zyzzyxdonta
Rename post to post[-_]process in various places
b10d0d4
@zyzzyxdonta
Spell noun with, verb without hyphen
0d44d87
@sdruskat
Merge remote-tracking branch 'origin/26-implement-processing-step' in…
f185a70 
…to 82-remove-quickfix-logging
@sdruskat
Merge pull request #92 from hermes-hmc/rename-post-to-post-process
120f5b3 
Rename post to postprocess in various places
@led02
Replace missing ep tag by harvester
41bcec5
@sdruskat
Merge branch '26-implement-processing-step' into 82-remove-quickfix-l…
4751dda 
…ogging
@sdruskat
Merge pull request #94 from hermes-hmc/82-remove-quickfix-logging
bb5b9df 
Remove experimental quickfix logging
@sdruskat
Merge remote-tracking branch 'origin/26-implement-processing-step' in…
9089729 
…to 85-fix-email-terminology
@led02
Fix some more flake8 issues (lines too long)
523863a
@sdruskat
Merge pull request #88 from hermes-hmc/85-fix-email-terminology
80d744b 
Fix #85: Improve email mapping terminology
@jkelling @sdruskat
test/hermes_test/model/test_harvest_context.py: Fix misplaced harvester
a6db2a8 
Co-authored-by: Stephan Druskat <sdruskat@users.noreply.github.com>
@sdruskat
Fix typo
e27de93
@led02
Merge pull request #90 from hermes-hmc/84-rename-ts-ep-et-al-in-herme…
e6b93e7 
…s-json-in-hermes-to-better-terms

Rename ts, ep => timestamp, harvester
@led02
Remove unneccessary HTML template
dd66d6e
sdruskat
sdruskat reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@sdruskat sdruskat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final comments to resolve, then I think this is good to go.

led02 and others added 2 commits January 11, 2023 15:21
@led02
Add commiter instead of setting some custom field
be159eb
@led02 @sdruskat
Apply suggestions from code review
fce075e 
Co-authored-by: Stephan Druskat <sdruskat@users.noreply.github.com>
@sdruskat sdruskat merged commit bea84b3 into develop Jan 11, 2023
@sdruskat sdruskat deleted the 26-implement-processing-step branch January 11, 2023 15:41
@led02 led02 mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdruskat sdruskat sdruskat approved these changes

@poikilotherm poikilotherm poikilotherm left review comments

+1 more reviewer

@jkelling jkelling jkelling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

5 participants

@led02 @sdruskat @poikilotherm @jkelling @zyzzyxdonta