Skip to content

fix: tokens loader use text and add esm output #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeasonstudio wants to merge 2 commits into from
Closed

fix: tokens loader use text and add esm output #83

jeasonstudio wants to merge 2 commits into from

Conversation

@jeasonstudio
Copy link

@jeasonstudio jeasonstudio commented Mar 28, 2023

  • fix esbuild text loader, its text but not file.
  • add esm output type.

@jeasonstudio
Copy link
Author

jeasonstudio commented Mar 31, 2023

Currently, there is an error in the loader configuration of esbuild, which causes the .tokens file to not be loaded correctly during the building process for browser targets. This results in incorrect tokenization. Please review this PR when you have time. Thanks.
@Janther @mattiaerre @naddison36 @fvictorio

frolic
frolic reviewed Apr 18, 2023
View reviewed changes
@alvrs alvrs mentioned this pull request Apr 19, 2023
Closed
@fvictorio
Copy link
Contributor

fvictorio commented Dec 7, 2023

Closing because of this. Happy to continue the discussion in the issue I opened.

@fvictorio fvictorio closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frolic frolic frolic left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeasonstudio @fvictorio @frolic