add exports to package.json to support usage in esm #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @alvrs, thanks for this (and sorry for taking so long to respond). I gave this a try locally but this is not working, even after some modifications. I think the reason is that the generated antlr code uses some dynamic requires that are not supported by esbuild. I'm not super sure what to do about this. Maybe we should only use esbuild for the browser build, and just tsc to generate the cjs and esm builds? I'm not sure. For the time being, I opened this issue about it so we can discuss it further there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportsto be able to use this package as esm package (based on fix: tokens loader use text and add esm output #83)