Mark ffaker as a common Spree dependency#2082
Closed
fredericboivin wants to merge 1 commit intosolidusio:masterfrom
Closed
Mark ffaker as a common Spree dependency#2082fredericboivin wants to merge 1 commit intosolidusio:masterfrom
fredericboivin wants to merge 1 commit intosolidusio:masterfrom
Conversation
fredericboivin
force-pushed
the
feature/ffaker
branch
2 times, most recently
from
65dfe75 to
7cece6d
Compare
FFaker is used by the test suite and should not be a production dependency. This commit moves `ffaker` to the :test group in common_spree_dependencies.rb
fredericboivin
force-pushed
the
feature/ffaker
branch
from
7cece6d to
9be25d4
Compare
Member
|
@dangerdogz I think ffaker is still needed as dependency since it is used to build sample data which could even be run in production. |
fredericboivin
changed the title
Contributor
Author
|
Will investigate more |
cbrunsdon
pushed a commit
to cbrunsdon/solidus
that referenced
this pull request
Aug 9, 2017
Continues the idea of solidusio#2082, this removes the dependency of ffaker but also yanks it out of the sample requirement. I generated a small data set with 15.times.map { FFaker::Name.first_name } etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FFaker is used by the test suite and should not be a production
dependency.