Remove the ffaker sample data dependency (revised)#2163
Merged
cbrunsdon merged 1 commit intosolidusio:masterfrom Aug 22, 2017
swcraig:finish-clarke-pr-2140
Merged
Remove the ffaker sample data dependency (revised)#2163cbrunsdon merged 1 commit intosolidusio:masterfrom swcraig:finish-clarke-pr-2140
cbrunsdon merged 1 commit intosolidusio:masterfrom
swcraig:finish-clarke-pr-2140
Conversation
Continues the idea of #2082, this removes the dependency of ffaker but also yanks it out of the sample requirement. I generated a small data set with 15.times.map { FFaker::Name.first_name } etc.
Contributor
Author
|
@tvdeyen I didn't change the name arrays to use |
tvdeyen
approved these changes
Aug 17, 2017
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks. I'totally fine with the array syntax 👌
cbrunsdon
approved these changes
Aug 17, 2017
Contributor
cbrunsdon
left a comment
cbrunsdon
left a comment
There was a problem hiding this comment.
Good by me, thanks for finishing this off sebastian
Contributor
|
Thanks! |
This was referenced Sep 7, 2017
This was referenced Sep 14, 2017
Merged
fastjames
pushed a commit
to geminimvp/solidus_subscriptions
that referenced
this pull request
Aug 1, 2018
ffaker was removed as a runtime dependency of Solidus. As of right now, this removal is only on Solidus master (but it is slated for v2.4). Even though this extension does not use ffaker directly, Solidus complains that its factories require the library and so the tests fail without this. PR removing ffaker from Solidus: solidusio/solidus#2163
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comments brought up in @cbrunsdon's original PR.
Original PR description
Continues the idea of #2082, this removes the dependency of ffaker but
also yanks it out of the sample requirement. I generated a small data
set with 15.times.map { FFaker::Name.first_name } etc.