Add ffaker dependency to gemspec#35
Merged
jacobherrington merged 2 commits intosolidusio:masterfrom Aug 23, 2018
swcraig:add-ffaker-dependency
Merged
Add ffaker dependency to gemspec#35jacobherrington merged 2 commits intosolidusio:masterfrom swcraig:add-ffaker-dependency
jacobherrington merged 2 commits intosolidusio:masterfrom
swcraig:add-ffaker-dependency
Conversation
ffaker was removed as a runtime dependency of Solidus. As of right now, this removal is only on Solidus master (but it is slated for v2.4). Even though this extension does not use ffaker directly, Solidus complains that its factories require the library and so the tests fail without this. PR removing ffaker from Solidus: solidusio/solidus#2163
mamhoff
previously approved these changes
Sep 7, 2017
qr8r
previously approved these changes
Sep 7, 2017
fastjames
previously approved these changes
Aug 3, 2018
Contributor
fastjames
left a comment
fastjames
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
jacobherrington
dismissed stale reviews from fastjames, qr8r, and mamhoff
via
43109f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffaker was removed as a runtime dependency of Solidus. As of right now,
this removal is only on Solidus master (but it is slated for v2.4).
Even though this extension does not use ffaker directly, Solidus
complains that its factories require the library and so the tests fail
without this.
PR removing ffaker from Solidus:
solidusio/solidus#2163
EDIT: The tests actually fail because of
require ffakerinspec/spec_helper.rb. But even removing this line will cause the tests to fail in the way described above.