Add ffaker dependency to gemspec#4
Closed
swcraig wants to merge 1 commit intosolidusio:masterfrom
swcraig:add-ffaker-dependency
Closed
Add ffaker dependency to gemspec#4swcraig wants to merge 1 commit intosolidusio:masterfrom swcraig:add-ffaker-dependency
swcraig wants to merge 1 commit intosolidusio:masterfrom
swcraig:add-ffaker-dependency
Conversation
ffaker was removed as a runtime dependency of Solidus. This gem itself requires ffaker: `lib/solidus_support/extensions/rails_helper.rb` Every Solidus extension that does not include ffaker will be broken. Adding the ffaker dependency here will fix all of the reverse dependencies of this gem: https://rubygems.org/gems/solidus_support/reverse_dependencies PR removing ffaker from Solidus: solidusio/solidus#2163
Author
|
I will add ffaker as a development dependency to the relevant gems instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffaker was removed as a runtime dependency of Solidus.
This gem itself requires ffaker:
lib/solidus_support/extensions/rails_helper.rbEvery Solidus extension that does not include ffaker will be broken.
Adding the ffaker dependency here will fix all of the reverse
dependencies of this gem:
https://rubygems.org/gems/solidus_support/reverse_dependencies
PR removing ffaker from Solidus:
solidusio/solidus#2163