Remove deprecated_address_id column from shipments#4379
Merged
waiting-for-dev merged 1 commit intosolidusio:masterfrom Apr 27, 2023
Merged
Conversation
waiting-for-dev
added
the
release:major
aldesantis
approved these changes
May 19, 2022
Member
|
@waiting-for-dev can you try to re-run the CI? |
Contributor
Author
Done. It's 🟢 now. |
kennyadsl
approved these changes
May 19, 2022
Contributor
Author
|
Rebasing to trigger CI |
waiting-for-dev
force-pushed
the
waiting-for-dev/readd_removal_of_deprecated_address_id
branch
from
b814ef2 to
7046254
Compare
3 tasks
waiting-for-dev
force-pushed
the
waiting-for-dev/readd_removal_of_deprecated_address_id
branch
from
7046254 to
f8bd900
Compare
waiting-for-dev
added a commit
that referenced
this pull request
Apr 27, 2023
db88911 set those two tests as `pending` because they were consistently failing. However, 5cdc40b removed the pending status because they started to work without problems. Now it's not clear which situations affect them. When they fail, they do it consistently (for instance, they affected #4379), but then sometimes they're ok. Until we have a better understanding, we'll just skip them, as they only affect the SQLite adapter.
We have not used this column since we removed all references to it in 2016. It was reverted on 039f3ce because of being backward incompatible. We re-add it now targeting next major (v4.0).
waiting-for-dev
force-pushed
the
waiting-for-dev/readd_removal_of_deprecated_address_id
branch
from
f8bd900 to
53eb16f
Compare
waiting-for-dev
deleted the
waiting-for-dev/readd_removal_of_deprecated_address_id
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have not used this column since we removed all references to it in
2016.
It was reverted on 039f3ce because of
being backward incompatible. We re-add it now targeting next major
(v4.0).
Ref #4377.
Thanks again for your understanding, @mamhoff.