Skip to content

Skip two randomly failing tests on SQLite#5046

Merged
waiting-for-dev merged 1 commit intomasterfrom
waiting-for-dev/revert_a_revert_for_pending_tests
Apr 27, 2023
Merged

Skip two randomly failing tests on SQLite#5046
waiting-for-dev merged 1 commit intomasterfrom
waiting-for-dev/revert_a_revert_for_pending_tests

Conversation

@waiting-for-dev
Copy link
Copy Markdown
Contributor

@waiting-for-dev waiting-for-dev commented Apr 26, 2023

Summary

db88911 set those two tests as pending because they were consistently failing. However, 5cdc40b removed the pending status because they started to work without problems.

Now it's not clear which situations affect them. When they fail, they do it consistently (for instance, they affected
#4379), but then sometimes they're ok. Until we have a better understanding, we'll just skip them, as they only affect the SQLite adapter.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev self-assigned this Apr 26, 2023
@waiting-for-dev waiting-for-dev requested a review from a team as a code owner April 26, 2023 07:57
@github-actions github-actions Bot added the changelog:solidus_api Changes to the solidus_api gem label Apr 26, 2023
@elia
Copy link
Copy Markdown
Member

elia commented Apr 26, 2023

It looks like they're again an issue, and #4379 is being affected.

You think we're dealing with a flakey or is it a hard stop for sqlite?
If it's a specific behavior I'm also wondering if we could add a reference to what is causing it in the pending message 🤔

@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/revert_a_revert_for_pending_tests branch 2 times, most recently from 745d3a4 to 438aa51 Compare April 26, 2023 09:30
@waiting-for-dev
Copy link
Copy Markdown
Contributor Author

You think we're dealing with a flakey or is it a hard stop for sqlite?
If it's a specific behavior I'm also wondering if we could add a reference to what is causing it in the pending message

It doesn't look flaky, as it fails consistently.

👍 I added the same we have for the first commit message as the pending failure. My understanding of the failure is not complete, so I can't be more precise.

@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/revert_a_revert_for_pending_tests branch from 438aa51 to 847d031 Compare April 26, 2023 13:14
db88911 set those two tests as
`pending` because they were consistently failing. However,
5cdc40b removed the pending status
because they started to work without problems.

Now it's not clear which situations affect them. When they fail, they do
it consistently (for instance, they affected
#4379), but then sometimes
they're ok. Until we have a better understanding, we'll just skip them,
as they only affect the SQLite adapter.
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/revert_a_revert_for_pending_tests branch from 847d031 to c4287e3 Compare April 27, 2023 04:00
@waiting-for-dev waiting-for-dev changed the title Revert "Restore SQLite specs that were previously skipped" Skip two randomly failing tests on SQLite Apr 27, 2023
@waiting-for-dev waiting-for-dev merged commit 48584c5 into master Apr 27, 2023
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/revert_a_revert_for_pending_tests branch April 27, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_api Changes to the solidus_api gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants