Skip two randomly failing tests on SQLite#5046
Merged
waiting-for-dev merged 1 commit intomasterfrom Apr 27, 2023
Merged
Conversation
rainerdema
approved these changes
Apr 26, 2023
Member
You think we're dealing with a flakey or is it a hard stop for sqlite? |
745d3a4 to
438aa51
Compare
Contributor
Author
It doesn't look flaky, as it fails consistently. 👍 I added the same we have for the first commit message as the pending failure. My understanding of the failure is not complete, so I can't be more precise. |
438aa51 to
847d031
Compare
db88911 set those two tests as `pending` because they were consistently failing. However, 5cdc40b removed the pending status because they started to work without problems. Now it's not clear which situations affect them. When they fail, they do it consistently (for instance, they affected #4379), but then sometimes they're ok. Until we have a better understanding, we'll just skip them, as they only affect the SQLite adapter.
847d031 to
c4287e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db88911 set those two tests as
pendingbecause they were consistently failing. However, 5cdc40b removed the pending status because they started to work without problems.Now it's not clear which situations affect them. When they fail, they do it consistently (for instance, they affected
#4379), but then sometimes they're ok. Until we have a better understanding, we'll just skip them, as they only affect the SQLite adapter.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: