Spree::ProductDuplicator bug on price#4971
Merged
waiting-for-dev merged 1 commit intosolidusio:masterfrom Mar 10, 2023
Merged
Conversation
Until v3.2.3 duplicating a product duplicated the price. Since v3.2.4 the product duplication does not duplicate the price. Looks like it comes from the PR solidusio#4639 :/ To fix it we duplicate all of the master prices on the new_product.
d58d896 to
00cac06
Compare
Codecov Report
@@ Coverage Diff @@
## master #4971 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 578 578
Lines 14685 14685
=======================================
Hits 12731 12731
Misses 1954 1954
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
@kennyadsl it should also be back-ported to v3.1 as the version 3.1.9 is also concerned |
Member
|
@Roddoric you are right, done! |
waiting-for-dev
approved these changes
Mar 10, 2023
This was referenced Mar 10, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Created to support #4970
Until v3.2.3 duplicating a product duplicated the price.
Since v3.2.4 the product duplication does not duplicate the price.
Looks like it comes from the PR #4639 :/
The code looks like price is supposed to be copied:
Spree::ProductDuplicator#duplicate_masterTo fix it I duplicated all of the master prices on the new_product.master.
Looks like it work for the test and for our app.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: