Skip to content

[v3.3] Spree::ProductDuplicator bug on price#4976

Merged
waiting-for-dev merged 1 commit intov3.3from
backport/v3.3/pr-4971
Mar 13, 2023
Merged

[v3.3] Spree::ProductDuplicator bug on price#4976
waiting-for-dev merged 1 commit intov3.3from
backport/v3.3/pr-4971

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions Bot commented Mar 10, 2023

Backport

This will backport the following commits from master to v3.3:

Questions ?

Please refer to the Backport tool documentation

@Roddoric
Duplicate master prices on product duplication
714035d 
Until v3.2.3 duplicating a product duplicated the price.
Since v3.2.4 the product duplication does not duplicate the price.

Looks like it comes from the PR #4639 :/

To fix it we duplicate all of the master prices on the new_product.

(cherry picked from commit 00cac06)
@github-actions github-actions Bot requested a review from a team as a code owner March 10, 2023 14:08
@github-actions github-actions Bot mentioned this pull request Mar 10, 2023
Merged
3 tasks
@waiting-for-dev waiting-for-dev changed the title [v3.3] Merge pull request #4971 from Roddoric/duplicate-price-on-product-duplication [v3.3] Spree::ProductDuplicator bug on price Mar 10, 2023
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Mar 10, 2023
@waiting-for-dev waiting-for-dev merged commit 7472f81 into v3.3 Mar 13, 2023
@waiting-for-dev waiting-for-dev deleted the backport/v3.3/pr-4971 branch March 13, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adammathys adammathys adammathys approved these changes

Assignees

No one assigned

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adammathys @waiting-for-dev @Roddoric