Raise on deprecation when SOLIDUS_RAISE_DEPRECATIONS set

[forkata]

Summary

Fixes #5766

This issue can be reproduced on the first commit by running the specs with the environment variable to override deprecation behaviour, as such

SOLIDUS_RAISE_DEPRECATIONS=true bundle exec rspec spec/lib/spree/deprecator_spec.rb

which produces the following output

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) Spree.deprecator by default does not raise an error unless overridden by environment
     # fix for deprecation behaviour override
     Failure/Error: expect { Dummy.new.deprecated_method }.to raise_error(ActiveSupport::DeprecationException)
       expected ActiveSupport::DeprecationException but nothing was raised

We were able to fix this issue by moving the code that sets the deprecation behaviour after the DummyApp is initialized, which seems to reset that.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[tvdeyen]

Nice work!

[benjaminwil]

It looks like this change has exposed some other tests that should have been raising exceptions but were not. (Because SOLIDUS_RAISE_DEPRECATIONS is set to true for CI runs.)

So we'll need to go back and fix those up before merging, it seems.

[kennyadsl]

Thanks for this! We should restore the previous behavior to spot failing specs for deprecations, like it's already happening it seems. Thanks again. ❤️

[benjaminwil]

Looks like we just need to rebase once #5814 is merged and all will be okay.

[kennyadsl]

We can rebase now, thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (8da6c2a) to head (586c519).
Report is 21 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5813   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         735      735           
  Lines       17172    17172           
=======================================
  Hits        15239    15239           
  Misses       1933     1933           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kennyadsl]

Thanks @forkata and @benjaminwil! ❤️