Skip to content

Decorate Default Return Refund Amount Calculator in LegacyPromotions#5845

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:fix-eligible-deprecations
Sep 2, 2024
Merged

Decorate Default Return Refund Amount Calculator in LegacyPromotions#5845
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:fix-eligible-deprecations

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented Sep 2, 2024

This calculator uses the eligible API from Spree::Adjustment, which in a system with the new promotions system will not be necessary.

This hasn't been caught before because deprecation warnings did not raise until #5813 was merged.

This calculator uses the `eligible` API from `Spree::Adjustment`, which
in a system with the new promotions system will not be necessary.

This hasn't been caught before because deprecation warnings did not
raise until solidusio#5813 was merged.
@mamhoff mamhoff requested a review from a team as a code owner September 2, 2024 12:41
@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label Sep 2, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (1aa18ee) to head (f739843).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...culator_returns_default_refund_amount_decorator.rb 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5845      +/-   ##
==========================================
+ Coverage   89.14%   89.17%   +0.03%     
==========================================
  Files         744      749       +5     
  Lines       17343    17395      +52     
==========================================
+ Hits        15460    15512      +52     
  Misses       1883     1883              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@MadelineCollier MadelineCollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants