Decorate Default Return Refund Amount Calculator in LegacyPromotions#5845
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Sep 2, 2024
Merged
Decorate Default Return Refund Amount Calculator in LegacyPromotions#5845tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
This calculator uses the `eligible` API from `Spree::Adjustment`, which in a system with the new promotions system will not be necessary. This hasn't been caught before because deprecation warnings did not raise until solidusio#5813 was merged.
kennyadsl
approved these changes
Sep 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5845 +/- ##
==========================================
+ Coverage 89.14% 89.17% +0.03%
==========================================
Files 744 749 +5
Lines 17343 17395 +52
==========================================
+ Hits 15460 15512 +52
Misses 1883 1883 ☔ View full report in Codecov by Sentry. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This calculator uses the
eligibleAPI fromSpree::Adjustment, which in a system with the new promotions system will not be necessary.This hasn't been caught before because deprecation warnings did not raise until #5813 was merged.