[Admin] Update Spree::Role admin UI with descriptions & required names#5844
Merged
MadelineCollier merged 3 commits intosolidusio:mainfrom Sep 2, 2024
Merged
Conversation
tvdeyen
approved these changes
Aug 30, 2024
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
I really appreciate the git history in this PR. A blessing to review and future selfs will thank you for this 👏🏻
Member
|
Spec failures seem to be unrelated. |
Contributor
Author
|
Spec failures should be fixed once this guy is merged: #5845 |
3 tasks
This can be re-added whenever we get around to adding a migration to add it to the spree_roles table. For now all we need is the :name & :description.
In a separate PR, descriptions were added to the spree_roles table, and validations were added so that names are now required to be present & unique. The admin specs now reflect that reality and the UI has been updated to display descriptions.
MadelineCollier
force-pushed
the
admin-role-creation-with-permissions
branch
from
618d90b to
275321b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5844 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 749 749
Lines 17395 17395
=======================================
Hits 15512 15512
Misses 1883 1883 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the existing Roles UI to work with descriptions (migrations for which were added in #5833) as part of this issue: #5823
The next PR should include the permission sets functionality, which is nearly there, but for now this can be broken off and reviewed separately!
Screen.Recording.2024-08-30.at.5.01.43.PM.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: