[Admin] Add new migrations and validations in core to support new admin Spree::Role interface #5833
Merged
MadelineCollier merged 3 commits intosolidusio:mainfrom Aug 29, 2024
Conversation
MadelineCollier
changed the title
github-actions
Bot
added
the
changelog:solidus_core
MadelineCollier
force-pushed
the
add-role-columns-validations
branch
from
560e327 to
45e4837
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5833 +/- ##
=======================================
Coverage 89.14% 89.14%
=======================================
Files 744 744
Lines 17343 17343
=======================================
Hits 15460 15460
Misses 1883 1883 ☔ View full report in Codecov by Sentry. |
3 tasks
elia
approved these changes
Aug 29, 2024
Member
elia
left a comment
elia
left a comment
There was a problem hiding this comment.
Added just a nit about using def change vs. def up / def down, but otherwise looks great! 🙌
MadelineCollier
force-pushed
the
add-role-columns-validations
branch
from
45e4837 to
98addef
Compare
MadelineCollier
changed the title
core to support new admin Spree::Role interface
MadelineCollier
changed the title
core to support new admin Spree::Role interface core to support new admin Spree::Role interface
It doesn't make a lot of sense to allow blank on this considering it is the only defining feature of a Role currently. Co-authored-by: benjamin wil <benjamin@super.gd>
MadelineCollier
force-pushed
the
add-role-columns-validations
branch
from
98addef to
98dc7f6
Compare
tvdeyen
reviewed
Aug 29, 2024
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Nice. Could we remove the unless check? It should not be necessary for Rails 7.0 and above.
These migrations originally come from `solidus_user_roles`. We intend to migrate some of the functionality from that extension into `core`, and this is the first step. With the table check, these migrations should be safe to (re)run for any store which might already have `solidus_user_roles` installed.
MadelineCollier
force-pushed
the
add-role-columns-validations
branch
from
98dc7f6 to
1aa18ee
Compare
tvdeyen
approved these changes
Aug 29, 2024
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Looking forward to this! Thanks for working on it 🍨
3 tasks
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this pull request
Sep 3, 2024
This is building off of the new migrations in solidusio#5833 These originate from `solidus_user_roles`. We intend to migrate some of the functionality from that extension into `core`, and this is the (second) step.
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this pull request
Sep 5, 2024
This is building off of the new migrations in solidusio#5833 These originate from `solidus_user_roles`. We intend to migrate some of the functionality from that extension into `core`, and this is the (second) step. Later commits also proved the need for an easier method of identifying and categorizing permission sets more cleanly on the front-end, which is why we added the category & privilege columns. Co-authored-by: benjamin wil <benjamin@super.gd>
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this pull request
Sep 5, 2024
This is building off of the new migrations in solidusio#5833 These originate from `solidus_user_roles`. We intend to migrate some of the functionality from that extension into `core`, and this is the (second) step. Later commits also proved the need for an easier method of identifying and categorizing permission sets more cleanly on the front-end, which is why we added the category & privilege columns. Co-authored-by: benjamin wil <benjamin@super.gd>
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this pull request
Sep 6, 2024
This is building off of the new migrations in solidusio#5833 These originate from `solidus_user_roles`. We intend to migrate some of the functionality from that extension into `core`, and this is the (second) step. Co-authored-by: benjamin wil <benjamin@super.gd>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of issue: #5823
These new migrations and validations are being added to support the example designs for the new roles admin interface:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: