[Admin] Edit/Update roles via new admin UI

[MadelineCollier]

Summary

This PR is part 2 of issue #5823 That first PR adds the basic Role UI (creation/deletion/index), while this PR adds the modification logic for editing/updating.

The attached video shows the functionality visually:
(Note that currently Spree::Role does not require name to be present, but when it is present, it must be unique)

Screen.Recording.2024-08-15.at.12.46.38.PM.mov

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (900c35a) to head (76ae9f6).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5828      +/-   ##
==========================================
+ Coverage   89.12%   89.14%   +0.01%     
==========================================
  Files         743      744       +1     
  Lines       17317    17343      +26     
==========================================
+ Hits        15434    15460      +26     
  Misses       1883     1883              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MadelineCollier]

This should remain in draft until #5826 has been merged and the branch can be rebased to remove the extra (related) commits.

[elia]

Left a nit comment, but LGTM 👍

I'm also wondering if we should just enforce the presence of a name for roles 🤔

[elia]

nit: thoughts on sticking to the convention used in rails scaffold code and use set_role here?

from rails g scaffold

  private
    # Use callbacks to share common setup or constraints between actions.
    def set_post
      @post = Post.find(params[:id])
    end

    # Only allow a list of trusted parameters through.
    def post_params
      params.require(:post).permit(:title, :body)
    end

[MadelineCollier]

Oh for sure, I'd be happy to switch to that! And yes, I feel strongly that we should validate the presence of names on Roles given they are the only defining characteristic at the moment. It would be great if you could take a look at my draft PR: #5833 and let me know of anything else you think I should consider as part of my modifications. Part of that PR is working to pull in some of the most essential pieces from the solidus_user_roles gem

[MadelineCollier]

Actually on second thought, @elia I might leave this as find_role for now, as you can see that this pattern of find_<resource_name> persists across many of our admin controllers. I think if we do change it I should change it for all of them.

[elia]

Great call, yes, let's do it in one pass for everything 👍

[MadelineCollier]

Sounds good, I can put that bulk rename change up today.