Create and Edit Product Property with UI components issue #5857 by Astr0surf3r · Pull Request #5892 · solidusio/solidus

Astr0surf3r · 2024-10-31T00:36:24Z

Summary

fix the issue #5857

Now to add a product property appear a modal

And to edit a Property appear a modal as well

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

jarednorman

@Astr0surf3r You have not followed our pull request guidelines:

The commit messages lack any explanation.
Some commits add unnecessary code that gets removed by later commits.
Linting changes shouldn't be in separate commits and your linting commit also removes unneeded code.

I'd appreciate a rebase of this PR to address these issues.

@MadelineCollier Can you take a pass over this from an implementation perspective and make sure it's consistent with how similar features are built? You have better knowledge of how admin features should be built.

jarednorman · 2024-10-31T21:33:40Z

+    def form_id
+      dom_id(@property, "#{stimulus_id}_edit_property_form")
+    end
+  end


This file is mostly misindented.

@jarednorman thank you for your message I have just already made rebase in this PR and follow the solidus guideline let me know if need a cleaner PR I can upload 1 single commit with all changes ... let me know please

codecov · 2024-11-02T18:32:12Z

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (b1849a5) to head (f95b07d).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
...controllers/solidus_admin/properties_controller.rb	95.65%	2 Missing ⚠️
.../solidus/install/app_templates/frontend/starter.rb	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5892      +/-   ##
==========================================
+ Coverage   89.54%   89.57%   +0.02%     
==========================================
  Files         783      785       +2     
  Lines       17994    18054      +60     
==========================================
+ Hits        16113    16171      +58     
- Misses       1881     1883       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit adds an introductory section telling the reader how the migration process works. It also adds a last section telling the reader to remove any ineligible adjustments from their database. Lastly, it corrects the location of Spree configuration from the `solidus_promotions` initializer to the `spree.rb` initializer.

We don't want to include `solidus_promotions` as a dependency in `solidus` yet, but we do want to release the gem, so it should appear in the all the lists of Solidus sub-gems.

This code has been automatically generated by our 'Prepare release' GitHub action. The actual release is not part of the automation, and it still needs to be manually done by a maintainer.

Due to the top level constant in testing.rake the release task was also trying to release frontend. Using a local variable instead.

This code has been automatically generated by our 'Prepare post-release' GitHub action. Make sure that: - [ ] The new release has been published, along with its tag. See https://github.com/solidusio/solidus/releases/tag/v4.4.0 - [ ] The corresponding patch branch exists. See https://github.com/solidusio/solidus/tree/v4.4 - [ ] The corresponding backport-v4.4 label exists. See https://github.com/solidusio/solidus/labels

tvdeyen · 2024-11-15T07:52:02Z

@Astr0surf3r Please rebase this branch wit latest main and make one commit with your changes only. Thanks for the contribution.

jarednorman · 2024-11-21T02:31:46Z

I think this looks reasonable, but can you please rebase this PR against our main branch. I'm not sure what went wrong with your previous rebase, but you've ended up with a bunch of extra commits in your PR that shouldn't be there.

MadelineCollier · 2024-12-05T12:44:19Z

The work started here has been pulled into #6011. Thanks for your contribution @Astr0surf3r !

Astr0surf3r requested a review from a team as a code owner October 31, 2024 00:36

github-actions Bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_admin labels Oct 31, 2024

Astr0surf3r changed the title ~~Create and Edit Product Property with UI components #5857~~ Create and Edit Product Property with UI components issue #5857 Oct 31, 2024

jarednorman requested changes Oct 31, 2024

View reviewed changes

Astr0surf3r force-pushed the create-edit-product-property branch 3 times, most recently from c399ad5 to 042abb4 Compare November 2, 2024 00:11

github-actions Bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Nov 2, 2024

Astr0surf3r force-pushed the create-edit-product-property branch from 042abb4 to f52b0cf Compare November 2, 2024 00:30

github-actions Bot removed changelog:solidus_api Changes to the solidus_api gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Nov 2, 2024

Astr0surf3r and others added 8 commits November 4, 2024 12:04

add link to edit route for product property

c05d55a

Merge branch 'main' into main

fc26130

Update return_reasons.rb

48432d0

Include solidus_promotions in release tasks

d7188a0

We don't want to include `solidus_promotions` as a dependency in `solidus` yet, but we do want to release the gem, so it should appear in the all the lists of Solidus sub-gems.

Prepare release for Solidus v4.4.0

2c191d9

This code has been automatically generated by our 'Prepare release' GitHub action. The actual release is not part of the automation, and it still needs to be manually done by a maintainer.

Fix release task

98a5bb3

Due to the top level constant in testing.rake the release task was also trying to release frontend. Using a local variable instead.

Astr0surf3r force-pushed the create-edit-product-property branch from 5d14ec2 to 1558c9e Compare November 13, 2024 20:49

github-actions Bot added changelog:solidus_core Changes to the solidus_core gem and removed changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Nov 13, 2024

github-actions Bot removed changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Nov 14, 2024

tvdeyen assigned Astr0surf3r Nov 15, 2024

tvdeyen mentioned this pull request Nov 15, 2024

[Admin] Add product properties admin UI #5926

Closed

3 tasks

Astr0surf3r force-pushed the create-edit-product-property branch from f95b07d to faee2d4 Compare November 19, 2024 19:28

github-actions Bot removed the changelog:solidus_core Changes to the solidus_core gem label Nov 19, 2024

Astr0surf3r force-pushed the create-edit-product-property branch from faee2d4 to 403c809 Compare November 19, 2024 19:34

github-actions Bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Nov 19, 2024

Astr0surf3r force-pushed the create-edit-product-property branch from 403c809 to 919004b Compare November 19, 2024 19:45

github-actions Bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Nov 19, 2024

add creation and editing product properties using UI components

9c5577b

Astr0surf3r force-pushed the create-edit-product-property branch from 919004b to 9c5577b Compare November 19, 2024 19:50

MadelineCollier closed this Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create and Edit Product Property with UI components issue #5857#5892

Create and Edit Product Property with UI components issue #5857#5892
Astr0surf3r wants to merge 10 commits intosolidusio:mainfrom
Astr0surf3r:create-edit-product-property

Astr0surf3r commented Oct 31, 2024 •

edited

Loading

Uh oh!

jarednorman left a comment

Uh oh!

jarednorman Oct 31, 2024

Uh oh!

Astr0surf3r Nov 4, 2024

Uh oh!

codecov Bot commented Nov 2, 2024 •

edited

Loading

Uh oh!

tvdeyen commented Nov 15, 2024

Uh oh!

jarednorman commented Nov 21, 2024

Uh oh!

MadelineCollier commented Dec 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Astr0surf3r commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

jarednorman left a comment

Choose a reason for hiding this comment

Uh oh!

jarednorman Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

Astr0surf3r Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Nov 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tvdeyen commented Nov 15, 2024

Uh oh!

jarednorman commented Nov 21, 2024

Uh oh!

MadelineCollier commented Dec 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Astr0surf3r commented Oct 31, 2024 •

edited

Loading

codecov Bot commented Nov 2, 2024 •

edited

Loading