[FIX] A few small tweaks for the new promotion admin#5953
Merged
tvdeyen merged 2 commits intosolidusio:mainfrom Dec 3, 2024
Merged
[FIX] A few small tweaks for the new promotion admin#5953tvdeyen merged 2 commits intosolidusio:mainfrom
tvdeyen merged 2 commits intosolidusio:mainfrom
Conversation
This helps fix an issue when creating a new promotion with a single code. Without the inverse_of parameter, our associated codes won't correctly infer that they're associated to a new promotion and will generate undefined method for nil errors. Co-authored-by: Alistair Norman <alistair@super.gd>
Unfortunately, our resource controller is hardcoded to look for a `Spree::<model_name>` object, which obviously doesn't work with the new promotion namespace. Co-authored-by: Alistair Norman <alistair@super.gd>
github-actions
Bot
added
the
changelog:solidus_promotions
3 tasks
kennyadsl
approved these changes
Nov 28, 2024
jarednorman
approved these changes
Nov 28, 2024
Member
|
Backport after #6016 |
tvdeyen
added
backport-v4.4
This was referenced Dec 6, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes a couple of small tweaks to fix a few issues with the new promotions admin:
inverse_ofoption to theSolidusPromotions::Promotion#codesassociation.model_classon the newAdmin::PromotionCodesController.Spreenamespace.Checklist