Fix(promotions): Add model_class method to PromotionCodesController#5980
Closed
mamhoff wants to merge 1 commit intosolidusio:mainfrom
Closed
Fix(promotions): Add model_class method to PromotionCodesController#5980mamhoff wants to merge 1 commit intosolidusio:mainfrom
mamhoff wants to merge 1 commit intosolidusio:mainfrom
Conversation
Because the new promotion system lives outside the `spree` namespace, we need to be diligent about adding `model_class` to all the controllers. I have not added a spec, because this only fails if solidus_legacy_promotions is not loaded, and that is not the case in our test suite.
github-actions
Bot
added
the
changelog:solidus_promotions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5980 +/- ##
==========================================
+ Coverage 87.81% 89.46% +1.64%
==========================================
Files 476 782 +306
Lines 11656 17999 +6343
==========================================
+ Hits 10236 16102 +5866
- Misses 1420 1897 +477 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Dec 3, 2024
Contributor
Author
|
Fixed in #5953 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the new promotion system lives outside the
spreenamespace, we need to be diligent about addingmodel_classto all the controllers.I have not added a spec, because this only fails if solidus_legacy_promotions is not loaded, and that is not the case in our test suite.