[FIX] Remove spacing at top of OrderShipping#ship method#5954
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Nov 30, 2024
Merged
[FIX] Remove spacing at top of OrderShipping#ship method#5954tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
github-actions
Bot
added
the
changelog:solidus_core
jarednorman
approved these changes
Nov 28, 2024
Newest version of Rubocop wants us to remove extra spacing at the top of method bodies.
adammathys
force-pushed
the
fix/new-rubocop-rules
branch
from
b714451 to
6d44a13
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5954 +/- ##
==========================================
- Coverage 89.45% 87.81% -1.65%
==========================================
Files 782 476 -306
Lines 17997 11656 -6341
==========================================
- Hits 16100 10236 -5864
+ Misses 1897 1420 -477 ☔ View full report in Codecov by Sentry. |
Contributor
|
backport to 4.0 - 4.4 |
tvdeyen
added
backport-v4.0
This was referenced Dec 2, 2024
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This was referenced Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newest version of Rubocop wants us to remove extra spacing at the top of method bodies.
Checklist