Use Order#email to show the order's email in new admin

[softr8]

Summary

spree_orders table has the column email which stores the email of
guest orders or users email for non guest orders. We should use
that in the new admin to display the email so that guest orders work
as well.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (be710f3) to head (deed35a).
Report is 1121 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5596   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files         685      685           
  Lines       16404    16406    +2     
=======================================
+ Hits        14531    14533    +2     
  Misses       1873     1873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jarednorman]

I'm not necessarily opposed to this change, but can you provide some more context? In all the stores I work on, the order email gets set to the user email for non-guest orders, so I'm not sure how much value this provides.

[softr8]

I'm not necessarily opposed to this change, but can you provide some more context? In all the stores I work on, the order email gets set to the user email for non-guest orders, so I'm not sure how much value this provides.

I have some apps that behave like PoS, where a logged-in user can create orders for others, this is just the view layer, it does not change anything at all, The previous admin used to render order.email instead of order.user&.email || order.email

[jarednorman]

How does users creating orders for others factor in? Shouldn't that use the created_by field?

[tvdeyen]

This is actually a bug fix, but I think we should just use order.email here, as this already takes your use case into account.

[tvdeyen]

@softr8 I made the change so that we can merge this in. Thanks for reporting.

[github-actions]

💔 Some backports could not be created

Status	Branch	Result
❌	v4.2	Backport failed because of merge conflicts You might need to backport the following PRs to v4.2: - Merge pull request #5993 from tvdeyen/harden-admin-feature-specs - test: Do not wait 30 seconds for a test to fail - test: Wait for modal to open before testing its content - Merge pull request #5979 from mamhoff/fix-missing-translation-spec - Merge pull request #5956 from mamhoff/allow-passing-in-user-class - Merge pull request #5954 from SuperGoodSoft/fix/new-rubocop-rules
❌	v4.3	Backport failed because of merge conflicts You might need to backport the following PRs to v4.3: - Merge pull request #5993 from tvdeyen/harden-admin-feature-specs - test: Wait for modal to open before testing its content - Merge pull request #5979 from mamhoff/fix-missing-translation-spec - Merge pull request #5956 from mamhoff/allow-passing-in-user-class - Merge pull request #5954 from SuperGoodSoft/fix/new-rubocop-rules
✅	v4.4

Manual backport

To create the backport manually run:

backport --pr 5596

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[tvdeyen]

💚 All backports created successfully

Status	Branch	Result
✅	v4.3

Questions ?

Please refer to the Backport tool documentation

[tvdeyen]

💚 All backports created successfully

Status	Branch	Result
✅	v4.2

Questions ?

Please refer to the Backport tool documentation

[softr8]

Thanks @tvdeyen !!!!