Test app task: Allow passing in user class#5956
Conversation
github-actions
Bot
added
the
changelog:solidus_core
Without this, every extension's test app always has `Spree::LegacyUser` configured. Mostly, that's fine, but for solidus_auth_devise, it'd be nicer if the generated spree.rb file would have `Spree.user_class = "Spree::User"` rather than `Spree::LegacyUser`.
tvdeyen
force-pushed
the
allow-passing-in-user-class
branch
from
77d7ada to
520efc0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5956 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 476 476
Lines 11656 11656
=======================================
Hits 10236 10236
Misses 1420 1420 ☔ View full report in Codecov by Sentry. |
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
Makes sense, thanks Martin!
|
I'd like to use this to get extensions to use the new loading mechanism from Flickwerk, and extensions are always tested against many Solidus versions. Can I have this backported to Solidus 4.0 - 4.4? |
tvdeyen
added
backport-v4.0
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
3 participants
Without this, every extension's test app always has
Spree::LegacyUserconfigured. Mostly, that's fine, but for solidus_auth_devise, it'd be nicer if the generated spree.rb file would haveSpree.user_class = "Spree::User"rather thanSpree::LegacyUser.See this spec failure as an example of what I mean :) solidusio/solidus_auth_devise@7478697#diff-8d002d054349f039bafc03785a785a1594ef6b4539298f59e84e95217a97abedR21
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: