RFC: Interface experiment#6
Closed
jhawthorn wants to merge 1 commit intosolidusio:masterfrom
jhawthorn:interface_experiment
Closed
RFC: Interface experiment#6jhawthorn wants to merge 1 commit intosolidusio:masterfrom jhawthorn:interface_experiment
jhawthorn wants to merge 1 commit intosolidusio:masterfrom
jhawthorn:interface_experiment
Conversation
|
i like where this is headed! |
Contributor
|
looking good to me! |
Contributor
Author
|
test this please |
|
sounds like we were all circling on an alternative approach to this. ok to close? |
Contributor
|
Yes, that sounds right. |
stewart
added a commit
to stewart/solidus
that referenced
this pull request
Dec 21, 2016
Store credit cancel
tvdeyen
pushed a commit
that referenced
this pull request
Aug 9, 2017
Adjust sidebar to new admin layout
JDutil
pushed a commit
to JDutil/solidus
that referenced
this pull request
Feb 6, 2020
Fix flaky spec
mamhoff
added a commit
to mamhoff/solidus
that referenced
this pull request
Jun 26, 2024
Add "Lane" enum to Promotion
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc @jordan-brough @athal7 @magnusvk @cbrunsdon @gmacdougall
Just an experimental application of what we were discussing. Dumped actions into the
Spree::Actionsnamespace and added the OrderInterface as sugar.