Revert "Merge pull request #6122 from mamhoff/create-manifest-js-in-g…

[mamhoff]

…enerated-apps"

This reverts commit bec42f6, reversing changes made to 37a5c8a.

Summary

This reverts #6122. If Rails 8 runs the install generator, the Rails process won't even start if the file is not present, and consequently our installer won't run either. The actual fix is this: solidusio/solidus_dev_support#229 - The sprockets manifest file needs to be present before even starting up a Rails process with Solidus in the Gemfile.

I guess we need to sort out the Sprockets removal next.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (1b4e1f4) to head (e760610).
Report is 21 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6124   +/-   ##
=======================================
  Coverage   88.67%   88.68%           
=======================================
  Files         830      830           
  Lines       18016    18014    -2     
=======================================
  Hits        15976    15976           
+ Misses       2040     2038    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tvdeyen]

I think we also need to fix it in bin/sandbox in this repo?

[tvdeyen]

Or we wait for rails/sprockets-rails#546 to be merged and released?