Generate Manifest file early in sandbox generation#229
Merged
tvdeyen merged 1 commit intosolidusio:use-github-actionsfrom Feb 14, 2025
Merged
Generate Manifest file early in sandbox generation#229tvdeyen merged 1 commit intosolidusio:use-github-actionsfrom
tvdeyen merged 1 commit intosolidusio:use-github-actionsfrom
Conversation
The sandbox wants to install Solidus and migrate before running the install generator. That's bad, because migrating requires the app to boot, and booting fails because Sprockets fails with an error if the `manifest.js` file is not present. Since the file is quite simple, we can just pass it into a heredoc. This is needed for Rails 8, where the install generator won't create the file for us.
Merged
4 tasks
ikraamg
added a commit
to nebulab/solidus_acts_as_tenant
that referenced
this pull request
Feb 20, 2025
ikraamg
added a commit
to nebulab/solidus_acts_as_tenant
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sandbox wants to install Solidus and migrate before running the install generator. That's bad, because migrating requires the app to boot, and booting fails because Sprockets fails with an error if the
manifest.jsfile is not present.Since the file is quite simple, we can just pass it into a heredoc. This is needed for Rails 8, where the install generator won't create the file for us.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: